Skip to content

fix(api): provide seed npcs.json fixture and safe file loader (#83) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rodrigoue9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): provide seed npcs.json fixture and safe file loader (#83) #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions api/src/jsons/npcs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"1": {
"name": "Comerciante de Armas",
"npcType": 10,
"idHead": 1,
"idBody": 1,
"movement": 0,
"objs": [
{ "item": 1, "cant": 50 },
{ "item": 2, "cant": 50 }
],
"drop": []
},
"2": {
"name": "Sacerdote",
"npcType": 2,
"idHead": 2,
"idBody": 2,
"movement": 0,
"objs": [],
"drop": []
}
}
6 changes: 6 additions & 0 deletions api/src/lib/gameData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,12 +250,18 @@ export function loadSeedNpcsJson(): Array<{
data: GameNpcRecordData;
}> {
const filePath = resolveSeedJsonPath("npcs.json", "npcs.compact.json");
if (!fs.existsSync(filePath)) {
return [];
}
return loadNpcsJsonFromFile(filePath);
}

export function loadNpcsJsonFromFile(
filePath: string,
): Array<{ id: number; data: GameNpcRecordData }> {
if (!fs.existsSync(filePath)) {
return [];
}
const raw = JSON.parse(fs.readFileSync(filePath, "utf8")) as NpcsById;
return Object.entries(raw)
.map(([id, data]) => ({ id: Number(id), data: normalizeNpcData(data) }))
Expand Down
Loading