fix(api): handle nulls in ranking query and log error stack trace (closes #84) - #114
Open
trexfr-ops wants to merge 3 commits into
Open
fix(api): handle nulls in ranking query and log error stack trace (closes #84)#114trexfr-ops wants to merge 3 commits into
trexfr-ops wants to merge 3 commits into
Conversation
11 tasks
Code Review ✅ ApprovedRefactors ranking query null handling and database migration scripts to resolve 500 errors on clean databases, while adding full error stack trace logging. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #84
This PR resolves the 500 error on the
/rankingendpoint when executed against a clean database and ensures full error logging.Key Changes
console.error("Error in GET /ranking handler:", error)inapi/src/server.tsso any future internal handler failures are captured in the server log.ciudadanos_matadosandcriminales_matadosinCOALESCEto guarantee safe arithmetic on nullable stats inapi/src/repositories/characters.ts.{ characters: [] }./claim #84
0x32BB3df5B74a594956a0f33Bc353511Fa759FCa4LPnftYop8yhRNQZstysT3vuJf3XkpQWKTC8Xo39uq9LoaM2rQEkgaaSfuThqHZTd18yGdJSXffkLwMbc1qpyu6866qcgt26sqw4dn2mlmp8d0yc657fuedkvDDMU6D9TCE3BhqqYyy7MUZQD7JhfL39FpESummary by Gitar
clan_memberstable definition before data migrations inapi/schema.sqlapi/src/migrate.tsThis will update automatically on new commits.