Skip to content

feat(world-builder): stage 3 live map reloading without server restart (#93) - #107

Open
Rodrigoue9 wants to merge 2 commits into
Bitcoindefi:mainfrom
Rodrigoue9:feat/bounty-93
Open

feat(world-builder): stage 3 live map reloading without server restart (#93)#107
Rodrigoue9 wants to merge 2 commits into
Bitcoindefi:mainfrom
Rodrigoue9:feat/bounty-93

Conversation

@Rodrigoue9

Copy link
Copy Markdown

Title

feat(world-builder): stage 3 live map reloading without server restart (#93)

Description

  • Adds reloadMapByNumber(mapNum) in server/src/loadMaps.ts to reload individual maps dynamically from disk.
  • Rebuilds runtime tiles, exits, objects, NPCs, triggers, and metadata without requiring a full game server reboot.
  • Relocates connected players from newly blocked tiles to safe default spawn (map 1, 50, 50).

Closes #93

Comment thread server/src/loadMaps.ts Outdated
@gitar-bot

gitar-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Adds live map reloading via reloadMapByNumber and dynamic tile rebuilding, addressing the uninitialized userConectados reference during player relocation. No issues found.

✅ 1 resolved
Bug: reloadMapByNumber player relocation never runs (userConectados undefined)

📄 server/src/loadMaps.ts:297-311 📄 server/src/loadMaps.ts:300-305 📄 server/src/loadMaps.ts:306-308
vars.userConectados is never defined anywhere in the codebase (vars.ts initializes this.clients = {} and characters live in vars.personajes; grep finds userConectados only here). Since it is always undefined, the entire if (vars.userConectados) block is dead code and no player is ever relocated off a newly-blocked tile — the core feature of this PR silently does nothing. Iterate over the real registry (e.g. vars.personajes) instead.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant