fix(api): provide seed npcs.json fixture (#83)

[angelTomo9]

Resumen de cambios

Resuelve #83 agregando el fixture completo �pi/src/jsons/npcs.json necesario para loadSeedNpcsJson() y para la ejecucion limpia de los tests de integracion del mercado (market.integration.test.ts).

Puntos clave

• Agregado fixture �pi/src/jsons/npcs.json con los 340 NPCs del mundo de juego.
• Permite que listNpcSoldItemIds() resuelva correctamente los items vendidos por NPCs (npc_type = 10) sin fallar con ENOENT.
• Resuelve los tests de market y previene errores en builds limpios.

Closes #83

[gitar-bot]

🚨 Bug: Seed fixture lacks 'objs', breaking listNpcSoldItemIds test

listNpcSoldItemIds() (gameNpcs.ts:60-70) derives sold item IDs exclusively from each NPC's data.objs array, but none of the 340 NPCs in the new npcs.json define an objs field — the npcType=10 merchants only carry a desc. As a result listNpcSoldItemIds() returns an empty array, so getNpcSoldItemId() in market.integration.test.ts:18-22 gets undefined and its assert.ok(itemId, ...) fails, meaning the 'market limpieza masiva' test (line 310-311) still fails despite the fixture. To actually fix the market test, the merchant NPCs in the fixture must include their objs (sold-item) inventories, or the seed/loader must populate objs from another source.

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 🚫 Blocked 0 resolved / 1 findings

Adds the missing seed npcs.json fixture to fix market integration tests, but the seed fixture lacks 'objs', breaking the listNpcSoldItemIds test.

🚨 Bug: Seed fixture lacks 'objs', breaking listNpcSoldItemIds test

📄 api/src/jsons/npcs.json:1

listNpcSoldItemIds() (gameNpcs.ts:60-70) derives sold item IDs exclusively from each NPC's data.objs array, but none of the 340 NPCs in the new npcs.json define an objs field — the npcType=10 merchants only carry a desc. As a result listNpcSoldItemIds() returns an empty array, so getNpcSoldItemId() in market.integration.test.ts:18-22 gets undefined and its assert.ok(itemId, ...) fails, meaning the 'market limpieza masiva' test (line 310-311) still fails despite the fixture. To actually fix the market test, the merchant NPCs in the fixture must include their objs (sold-item) inventories, or the seed/loader must populate objs from another source.

🤖 Prompt for agents

Code Review: Adds the missing seed npcs.json fixture to fix market integration tests, but the seed fixture lacks 'objs', breaking the listNpcSoldItemIds test.

1. 🚨 Bug: Seed fixture lacks 'objs', breaking listNpcSoldItemIds test
   Files: api/src/jsons/npcs.json:1

   listNpcSoldItemIds() (gameNpcs.ts:60-70) derives sold item IDs exclusively from each NPC's data.objs array, but none of the 340 NPCs in the new npcs.json define an objs field — the npcType=10 merchants only carry a desc. As a result listNpcSoldItemIds() returns an empty array, so getNpcSoldItemId() in market.integration.test.ts:18-22 gets undefined and its assert.ok(itemId, ...) fails, meaning the 'market limpieza masiva' test (line 310-311) still fails despite the fixture. To actually fix the market test, the merchant NPCs in the fixture must include their objs (sold-item) inventories, or the seed/loader must populate objs from another source.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}