Rust Analyzer and clippy without cmake #819

NickeZ · 2021-10-21T11:33:43Z

Works on my machine, but needs some testing on other developers setups.

If you can run cmake build-build && cd build-build && make rust-bindgen-includes it should work. (this means you have nanopb and bindgen working on your development machine).

benma · 2021-10-21T11:52:13Z

Wow I think it is working 😍

Is it possible to skip the tempdir dependency? Pulling in 3k+ files int the vendor lib is bit heavy, maybe there is a simple alternative that does not need that (cc @x1ddos )

NickeZ · 2021-10-21T11:54:26Z

cool! yeah I it seems to come from platform independent random number generation.. :( I'm not really happy about it either.

NickeZ · 2021-10-21T12:02:40Z

I swapped tempdir for temp-dir which has fewer dependencies, but isn't from rust-lang devs.

benma · 2021-11-10T15:13:21Z

src/rust/bitbox02-sys/build.rs

+        let tempdir = tempdir.path().to_str().unwrap();
+        let _ = Command::new("cmake").arg(&cmake_dir).current_dir(&tempdir).output().unwrap();
+        let _ = Command::new("make").arg("rust-bindgen-includes").current_dir(&tempdir).output().unwrap();
+        let mut includes_file = File::open(format!("{}/src/rust-bindgen.flags", tempdir)).unwrap();


I panic here if I go for example to src/rust/bitbox02-rust/src/hww/api/set_device_name.rs and run cargo test. Any idea?

I'm not sure exactly what you see, but I see a thing that think is wrong. When you run "cargo test" on a crate it will not compile "test versions" of the dependencies. So basically the tests in "bitbox02-rust" should not depend on a feature called "testing" in the "bitbox02" crate.

One workaround seems to be to use cargo test --all-features. ~~But the "testing" feature isn't additive, so it doesn't compile.~~

~~https://doc.rust-lang.org/cargo/reference/features.html~~

~~A consequence of this is that features should be additive. That is, enabling a feature should not disable functionality, and it should usually be safe to enable any combination of features.~~

Scratch that, I had a brainfart. It didn't work with --all-features. It probably has to link in some C code or something...

Good point, I forgot to enable the testing feature, but as you noticed, it still does not work.

Rust-analyzer seems to be working with this PR though, and also clippy seems to work. Just cargo test seems to fail at this line. The error is:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', bitbox02-sys/build.rs:19:91

Yeah cargo test is more complicated than clippy and RA since it has to do the final step of linking a working executable together. I'll see how hard it would be to support it

NickeZ · 2021-11-12T11:35:03Z

It works with cargo test now as well. The first run takes some time (it compiles the whole project), but subsequent should go fast.

depends on #831

Run like this: cargo test --features=testing

NickeZ · 2021-11-16T09:54:39Z

The reason this depends on #829 or #831 is that this PR crates a cmake build directory in the rust workspace. When running cargo in the rust workspace it gets configured to only use vendored code. So Either prost-build must be vendored or it must be pre-compiled for the cmake build directory to be able to use it when the cmake build directory is in the target dir of the rust workspace.

NickeZ · 2021-11-20T21:55:27Z

rebased on master

benma · 2021-11-30T23:37:27Z

@NickeZ

Run like this: cargo test --features=testing

This feature is not defined in the bitbox02-rust crate.

If I add testing = ["bitbox02/testing"] to this crate, and run the above in e.g. signmsg.rs, I get:

error: failed to run custom build command for `bitbox02-sys v0.1.0 (src/rust/bitbox02-sys)`

Caused by:
  process didn't exit successfully: `src/rust/target/debug/build/bitbox02-sys-9071871369c1a980/build-script-build` (exit status: 101)
  --- stdout
  [ 50%] Generating hww.pb.c, backup.pb.c, common.pb.c, backup_commands.pb.c, bitbox02_system.pb.c, btc.pb.c, cardano.pb.c, eth.pb.c, mnemonic.pb.c, system.pb.c, perform_attestation.pb.c, keystore.pb.c, antiklepto.pb.c, hww.pb.h, backup.pb.h, common.pb.h, backup_commands.pb.h, bitbox02_system.pb.h, btc.pb.h, cardano.pb.h, eth.pb.h, mnemonic.pb.h, system.pb.h, perform_attestation.pb.h, keystore.pb.h, antiklepto.pb.h
  messages/CMakeFiles/generate-protobufs.dir/build.make:110: recipe for target 'messages/hww.pb.c' failed
  CMakeFiles/Makefile2:1217: recipe for target 'messages/CMakeFiles/generate-protobufs.dir/all' failed
  CMakeFiles/Makefile2:1343: recipe for target 'src/CMakeFiles/rust-bindgen-includes.dir/rule' failed
  Makefile:610: recipe for target 'rust-bindgen-includes' failed


           *************************************************************
           *** Could not import the Google protobuf Python libraries ***
           *** Try installing package 'python-protobuf' or similar.  ***
           *************************************************************
      
  Traceback (most recent call last):
    File "../../../../../../../../../tools/nanopb/generator/protoc", line 4, in <module>
      from nanopb_generator import invoke_protoc
    File "tools/nanopb/generator/nanopb_generator.py", line 27, in <module>
      import google.protobuf.text_format as text_format
  ImportError: No module named google.protobuf.text_format
  make[3]: *** [messages/hww.pb.c] Error 1
  make[2]: *** [messages/CMakeFiles/generate-protobufs.dir/all] Error 2
  make[1]: *** [src/CMakeFiles/rust-bindgen-includes.dir/rule] Error 2
  make: *** [rust-bindgen-includes] Error 2


  --- stderr
  thread 'main' panicked at 'explicit panic', bitbox02-sys/build.rs:34:13
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Rust-analyzer also seems to not work anymore in this crate, while it worked in a previous iteration of this PR 🤔

Any idea what is going on?

NickeZ · 2021-12-01T08:12:48Z

Can you run this outside of docker? cmake build-build && cd build-build && make rust-bindgen-includes

I added the testing feature to the bitbox02-rust crate and now it works for me.

NickeZ force-pushed the ra-clippy-without-cmake branch 5 times, most recently from 288593b to 5844f74 Compare October 21, 2021 11:46

NickeZ force-pushed the ra-clippy-without-cmake branch from 5844f74 to 90c03df Compare October 21, 2021 12:01

NickeZ force-pushed the ra-clippy-without-cmake branch from 90c03df to c60907b Compare October 21, 2021 12:07

NickeZ requested a review from benma October 21, 2021 12:11

NickeZ force-pushed the ra-clippy-without-cmake branch from c60907b to b74de23 Compare October 21, 2021 12:13

benma reviewed Nov 10, 2021

View reviewed changes

NickeZ force-pushed the ra-clippy-without-cmake branch 5 times, most recently from a936fa1 to cee24a4 Compare November 12, 2021 11:34

NickeZ requested a review from benma November 12, 2021 11:34

NickeZ force-pushed the ra-clippy-without-cmake branch from cee24a4 to c233336 Compare November 12, 2021 12:04

NickeZ mentioned this pull request Nov 16, 2021

prost: Pre-compile the tool #829

Merged

NickeZ force-pushed the ra-clippy-without-cmake branch from c233336 to 434691d Compare November 20, 2021 21:51

NickeZ added 2 commits November 22, 2021 10:18

rust: move bindgen whitelist to separate file

6bd7dbe

rust: enable bindings to be built without existing cmake build dir

22075a4

NickeZ force-pushed the ra-clippy-without-cmake branch 2 times, most recently from 396899c to c817c42 Compare November 22, 2021 12:11

rust: Allow cargo to create c libs as needed for tests

f970b6c

NickeZ force-pushed the ra-clippy-without-cmake branch from c817c42 to f970b6c Compare December 1, 2021 08:09

benma mentioned this pull request Aug 9, 2022

Add rust-analyzer to dev dockerfile #963

Closed

NickeZ closed this Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rust Analyzer and clippy without cmake #819

Rust Analyzer and clippy without cmake #819

NickeZ commented Oct 21, 2021

benma commented Oct 21, 2021

NickeZ commented Oct 21, 2021 •

edited

Loading

NickeZ commented Oct 21, 2021

benma Nov 10, 2021

NickeZ Nov 10, 2021

NickeZ Nov 10, 2021 •

edited

Loading

benma Nov 10, 2021

NickeZ Nov 10, 2021

NickeZ commented Nov 12, 2021 •

edited

Loading

NickeZ commented Nov 16, 2021

NickeZ commented Nov 20, 2021

benma commented Nov 30, 2021 •

edited

Loading

NickeZ commented Dec 1, 2021

Rust Analyzer and clippy without cmake #819

Rust Analyzer and clippy without cmake #819

Conversation

NickeZ commented Oct 21, 2021

benma commented Oct 21, 2021

NickeZ commented Oct 21, 2021 • edited Loading

NickeZ commented Oct 21, 2021

benma Nov 10, 2021

Choose a reason for hiding this comment

NickeZ Nov 10, 2021

Choose a reason for hiding this comment

NickeZ Nov 10, 2021 • edited Loading

Choose a reason for hiding this comment

benma Nov 10, 2021

Choose a reason for hiding this comment

NickeZ Nov 10, 2021

Choose a reason for hiding this comment

NickeZ commented Nov 12, 2021 • edited Loading

NickeZ commented Nov 16, 2021

NickeZ commented Nov 20, 2021

benma commented Nov 30, 2021 • edited Loading

NickeZ commented Dec 1, 2021

NickeZ commented Oct 21, 2021 •

edited

Loading

NickeZ Nov 10, 2021 •

edited

Loading

NickeZ commented Nov 12, 2021 •

edited

Loading

benma commented Nov 30, 2021 •

edited

Loading