bitcoin: add support for OP_RETURN outputs #1606
Open
+305
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove our own code to improve clarity.
We enforce 0 value on them, so the confirmation screen is not a the usual recipient component, but can be a full screen confirmation not showing the amount. We use verify_message flow as it handles both ascii/binary. We also only support OP_RETURN outputs with one data push, though an OP_RETURN output could contain multiple data pushes. This restriction is for simplicity and because we don't know of a use case. In the future, support for this can be added if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api-go counterpart: BitBoxSwiss/bitbox02-api-go#141
builds on #1605