simulator: fix task poll speed #1602
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simulator didn't behave like the real firmware: it only polled/spun the async tasks when there was USB input available, which happens at the client poll interval during a long-running workflow. Instead, usb_packet_process should be called if there is USB input, but the async tasks should be polled independently at max speed. We noticed this issue when making bip39-unlock async, and it would only advance by one bip39 stretch iteration every few hundred milliseconds.
|
Does this make the simulator use 100% of one cpu thread? Maybe a quickfix could be to sleep 10 ms in the main loop? (the real fix is to change to an event loop that blocks if there is nothing more to do) |
Reduce CPU load
Yeah I have a version where it does a timeout like this (pushed the commit here), but there is no good balance.
That is not an easy thing to do at the moment right? For now I am abandoning this PR and simply making bip39 unlock not yield in every iteration in the simulator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simulator didn't behave like the real firmware: it only polled/spun the async tasks when there was USB input available, which happens at the client poll interval during a long-running workflow.
Instead, usb_packet_process should be called if there is USB input, but the async tasks should be polled independently at max speed.
We noticed this issue when making bip39-unlock async, and it would only advance by one bip39 stretch iteration every few hundred milliseconds.