btc: fix requesting previous transactions when not needed #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not needed and not idiomatic.
The previous transaction of every input in a Bitcoin transaction needs to be streamed to the BitBox, unless all inputs are Taproot inputs. They are needed for the BitBox to verify the input amount. Since Taproot, that is not necessary because all input amounts are part of the sighash. The firmware currently inspects the "scriptConfigs" to determine if all inputs are taproot. Bug: the scriptConfigs is also used to indicate outputs belonging to the same account (either change outputs or outputs verified as "This BitBox (same account): …". As a result, if all inputs are Taproot, but the change output is not Taproot (or coins are sent to a non-Taproot address of the same account), then previous transactions are requested/streamed even if they don't need to be. Fix: we let the client libraries set the flag if prevtxs are required or not, and reject the transaction if they set it to "not required" even if there is a non-Taproot input present. The previous way is preserved for backwards compatibility with client libraries that do not set this new flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.