Allow spaces while parsing Table Type - #96
Merged
Conversation
rscales
approved these changes
Aug 25, 2025
alinaliBQ
approved these changes
Aug 25, 2025
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
LGTM. The unit tests arrow-arrow-odbc-spi-impl-test.exe are passing on my end
There was a problem hiding this comment.
Good catch. I remember this bug. When I was testing before, I put down "BASE TABLE" and it didn't work, so I used single quotes to wrap "'BASE TABLE'" which worked, so I thought it was fine. But by checking SQLTables doc, each keyword can be quoted or unquoted, so this is a bug for sure.
It's good that we are fixing this now
justing-bq
force-pushed
the
tableTypeSpaces
branch
from
August 26, 2025 18:11
b72c141 to
1ba4f88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for users to include spaces in their
TableTypevalue when callingSQLTables(). This is necessary because one of our table types is "BASE TABLE".Before this change "BASE TABLE" would be internally converted to "BASETABLE" which resulted in
SQLTablesreturning 0 results.