Indicate Driver Company and Version on Driver Manager - #93
Merged
Conversation
* dll properties cannot be added
* use `1 VERSIONINFO` for it to work properly
alinaliBQ
force-pushed
the
odbc_version_rc
branch
from
August 22, 2025 23:06
104ab93 to
53d8b78
Compare
Author
|
Ran into unexpected build errors specific to the CI environment, will work on these on Monday |
rscales
reviewed
Aug 23, 2025
| #define VER_FILEVERSION @VER_FILEVERSION@ | ||
| #define VER_FILEVERSION_STR "@VER_FILEVERSION_STR@\0" | ||
|
|
||
| #define VER_PRODUCTVERSION @VER_FILEVERSION@ |
There was a problem hiding this comment.
Should the values be @VER_PRODUCTVERSION@ and @VER_PRODUCTVERSION_STR@
rscales
approved these changes
Aug 23, 2025
justing-bq
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.dllinformation to the driver.dlland indicates the driver version and company name. We use arcfile to indicate this.