Skip to content

mac build changes - #92

Merged
vic-tsang merged 1 commit into
apache-odbcfrom
mac-build
Aug 29, 2025
Merged

mac build changes#92
vic-tsang merged 1 commit into
apache-odbcfrom
mac-build

Conversation

@vic-tsang

Copy link
Copy Markdown

Rationale for this change

  • Add mac support for compiling ODBC

What changes are included in this PR?

  • Changed compile settings to be able to build in mac
  • Added if conditional statements for windows only code

Are these changes tested?

Yes locally (currently the mac workflow is not passing due to another issue not related to this PR )

Are there any user-facing changes?

No

@alinaliBQ

Copy link
Copy Markdown

JFYI to reviewers - Victor has checked and verified the macOS13/14 fails are inside Arrow and not from our code: apache#47399

Comment thread cpp/src/arrow/flight/sql/odbc/flight_sql/address_info.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/tests/columns_test.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc Outdated
@alinaliBQ

alinaliBQ commented Aug 27, 2025

Copy link
Copy Markdown

To adjust this PR, you could create a new branch mac-build2 based on apache-odbc and cherry-pick these 2 commits:
2507bd8f7c81dbadc09340b355fefd284afadb97 mac build changes and 12a97a0530cb8e57caf2bf2ac7946ebbaed47be6 check for flag.
Then you can run git push origin mac-build2:mac-build --force which will update mac-build

Comment thread cpp/cmake_modules/DefineOptions.cmake Outdated

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one change remaining

@vic-tsang

Copy link
Copy Markdown
Author

Cleaned up branch ready to merge

@vic-tsang
vic-tsang merged commit bc78dc8 into apache-odbc Aug 29, 2025
alinaliBQ pushed a commit that referenced this pull request Sep 9, 2025
added changes to build in MacOS
alinaliBQ pushed a commit that referenced this pull request Sep 25, 2025
added changes to build in MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants