Fix bug of DSN not read properly - #67
Merged
Merged
Conversation
Use a simpler, more robust way to load the DSN
alinaliBQ
marked this pull request as ready for review
July 18, 2025 23:09
jduo
approved these changes
Jul 19, 2025
rscales
approved these changes
Jul 23, 2025
alinaliBQ
added a commit
that referenced
this pull request
Jul 31, 2025
* Fix reading DSN bug Use a simpler, more robust way to load the DSN
alinaliBQ
added a commit
that referenced
this pull request
Aug 20, 2025
* Fix reading DSN bug Use a simpler, more robust way to load the DSN
alinaliBQ
added a commit
that referenced
this pull request
Aug 26, 2025
* Fix reading DSN bug Use a simpler, more robust way to load the DSN
alinaliBQ
added a commit
that referenced
this pull request
Sep 9, 2025
* Fix reading DSN bug Use a simpler, more robust way to load the DSN
alinaliBQ
added a commit
that referenced
this pull request
Sep 25, 2025
* Fix reading DSN bug Use a simpler, more robust way to load the DSN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that
loadPropertiesFromDSNwas not returning a correctpropertiesobject. I didn't dive into why but was having connection issues. So I fixed it to use more robustloadDSNfunction instead.Add test case to verify fix