SQLColumns Implementation

cpp/src/arrow/flight/sql/odbc/entry_points.cc

@@ -198,16 +198,9 @@ SQLRETURN SQL_API SQLColumns(SQLHSTMT stmt, SQLWCHAR* catalogName,
                              SQLSMALLINT schemaNameLength, SQLWCHAR* tableName,
                              SQLSMALLINT tableNameLength, SQLWCHAR* columnName,
                              SQLSMALLINT columnNameLength) {
-  LOG_DEBUG(
-      "SQLColumnsW called with stmt: {}, catalogName: {}, catalogNameLength: "
-      "{}, "
-      "schemaName: {}, schemaNameLength: {}, tableName: {}, tableNameLength: {}, "
-      "columnName: {}, "
-      "columnNameLength: {}",
-      stmt, fmt::ptr(catalogName), catalogNameLength, fmt::ptr(schemaName),
-      schemaNameLength, fmt::ptr(tableName), tableNameLength, fmt::ptr(columnName),
-      columnNameLength);
-  return SQL_ERROR;
+  return arrow::SQLColumns(stmt, catalogName, catalogNameLength, schemaName,
+                           schemaNameLength, tableName, tableNameLength, columnName,
+                           columnNameLength);
 }
 
 SQLRETURN SQL_API SQLError(SQLHENV handleType, SQLHDBC handle, SQLHSTMT hstmt,

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

@@ -1112,4 +1112,39 @@ SQLRETURN SQLRowCount(SQLHSTMT stmt, SQLLEN* rowCountPtr) {
     return SQL_SUCCESS;
   });
 }
+
+SQLRETURN SQLColumns(SQLHSTMT stmt, SQLWCHAR* catalogName, SQLSMALLINT catalogNameLength,
+                     SQLWCHAR* schemaName, SQLSMALLINT schemaNameLength,
+                     SQLWCHAR* tableName, SQLSMALLINT tableNameLength,
+                     SQLWCHAR* columnName, SQLSMALLINT columnNameLength) {
+  // GH-47159: Return NUM_PREC_RADIX based on whether COLUMN_SIZE contains number of
+  // digits or bits
+  LOG_DEBUG(
+      "SQLColumnsW called with stmt: {}, catalogName: {}, catalogNameLength: "
+      "{}, "
+      "schemaName: {}, schemaNameLength: {}, tableName: {}, tableNameLength: {}, "
+      "columnName: {}, "
+      "columnNameLength: {}",
+      stmt, fmt::ptr(catalogName), catalogNameLength, fmt::ptr(schemaName),
+      schemaNameLength, fmt::ptr(tableName), tableNameLength, fmt::ptr(columnName),
+      columnNameLength);
+
+  using ODBC::ODBCStatement;
+  using ODBC::SqlWcharToString;
+
+  return ODBCStatement::ExecuteWithDiagnostics(stmt, SQL_ERROR, [=]() {
+    ODBCStatement* statement = reinterpret_cast<ODBCStatement*>(stmt);
+
+    std::string catalog = SqlWcharToString(catalogName, catalogNameLength);
+    std::string schema = SqlWcharToString(schemaName, schemaNameLength);
+    std::string table = SqlWcharToString(tableName, tableNameLength);
+    std::string column = SqlWcharToString(columnName, columnNameLength);
+
+    statement->GetColumns(catalogName ? &catalog : nullptr,
+                          schemaName ? &schema : nullptr, tableName ? &table : nullptr,
+                          columnName ? &column : nullptr);
+
+    return SQL_SUCCESS;
+  });
+}
 }  // namespace arrow

cpp/src/arrow/flight/sql/odbc/odbc_api.h

@@ -79,4 +79,8 @@ SQLRETURN SQLGetData(SQLHSTMT stmt, SQLUSMALLINT recordNumber, SQLSMALLINT cType
 SQLRETURN SQLMoreResults(SQLHSTMT stmt);
 SQLRETURN SQLNumResultCols(SQLHSTMT stmt, SQLSMALLINT* columnCountPtr);
 SQLRETURN SQLRowCount(SQLHSTMT stmt, SQLLEN* rowCountPtr);
+SQLRETURN SQLColumns(SQLHSTMT stmt, SQLWCHAR* catalogName, SQLSMALLINT catalogNameLength,
+                     SQLWCHAR* schemaName, SQLSMALLINT schemaNameLength,
+                     SQLWCHAR* tableName, SQLSMALLINT tableNameLength,
+                     SQLWCHAR* columnName, SQLSMALLINT columnNameLength);
 }  // namespace arrow

cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt

@@ -31,6 +31,7 @@ set(ARROW_FLIGHT_SQL_MOCK_SERVER_SRCS
 
 add_arrow_test(flight_sql_odbc_test
                SOURCES
+               columns_test.cc
                connection_attr_test.cc
                connection_info_test.cc
                statement_attr_test.cc