GH-46584 Iterate endpoint - #63
Merged
Merged
Conversation
* use suggestion from James for one-liner change
alinaliBQ
force-pushed
the
gh-46584-iterate-endpoint
branch
from
July 12, 2025 00:05
d01f18e to
6cb1ad3
Compare
Add `arrow_flight_sql_shared` to enable usages for `TestFlightServer`
Update flight_sql_stream_chunk_buffer_test.cc Add `FlightStreamChunkBufferTest` unit test Draft test with `FlightSQLODBCMockEndpointTestBase`
alinaliBQ
force-pushed
the
gh-46584-iterate-endpoint
branch
from
July 15, 2025 20:22
83b4b45 to
b1ad70f
Compare
alinaliBQ
commented
Jul 15, 2025
Comment on lines
293
to
297
| PRIVATE_INCLUDES | ||
| "${Protobuf_INCLUDE_DIRS}") | ||
| "${Protobuf_INCLUDE_DIRS}" | ||
| SHARED_PRIVATE_LINK_LIBS | ||
| GTest::gmock) | ||
|
|
Author
There was a problem hiding this comment.
This is the fix for the 12 build errors on the local environment. Rob and I have both seen this issue before. I am not sure why it is only visible in our local environments and not seen in CI
Comment on lines
+61
to
+63
| // Return OK Status. The server should ignore this and just accept any Handshake | ||
| // request. | ||
| return outgoing->Write(std::string()); | ||
| return arrow::Status::OK(); |
Author
There was a problem hiding this comment.
After the original flightsql-odbc code has been written, Arrow API changed and now would need OK to be returned directly instead of writing strings
alinaliBQ
marked this pull request as ready for review
July 15, 2025 20:42
jduo
approved these changes
Jul 15, 2025
Real fix to connection
alinaliBQ
commented
Jul 17, 2025
| @@ -21,38 +21,71 @@ | |||
| namespace driver { | |||
| namespace flight_sql { | |||
|
|
|||
Author
|
Fixed merge conflicts |
rscales
reviewed
Jul 17, 2025
rscales
reviewed
Jul 17, 2025
rscales
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work on apache#46584