SQLBindCol Implementation - #59
Merged
Merged
Conversation
alinaliBQ
marked this pull request as ready for review
July 14, 2025 21:38
rscales
approved these changes
Jul 15, 2025
jduo
reviewed
Jul 15, 2025
| ODBCStatement* statement = reinterpret_cast<ODBCStatement*>(handle); | ||
| ODBCDescriptor* ard = statement->GetARD(); | ||
| // Unbind columns | ||
| ard->SetHeaderField(SQL_DESC_COUNT, (void*)0, 0); |
There was a problem hiding this comment.
Was there a method that you need to run to notify that binding changes have occurred (I forget).
Author
There was a problem hiding this comment.
I think not. The driver sets m_hasBindingsChanged to true after setting SQL_DESC_COUNT(code), so this boolean would indicate that binding has changed. The driver also sets m_hasBindingsChanged to true as part of underlying SQLBindCol code. So no method would need to be run.
There is method ODBCDescriptor::NotifyBindingsHaveChanged (code) that does the same thing to set m_hasBindingsChanged to true, maybe this is the method that you were thinking of? This method is called as part of ODBCStatement::closeCursor
jduo
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement SQLBindCol and tests