SQLPrepare & SQLExecute Implementation - #58
Merged
Conversation
alinaliBQ
commented
Jul 4, 2025
alinaliBQ
force-pushed
the
sql-prepare-sql-execute
branch
from
July 4, 2025 21:15
6752d0a to
610365e
Compare
alinaliBQ
force-pushed
the
sql-prepare-sql-execute
branch
from
July 4, 2025 21:16
610365e to
36e358d
Compare
alinaliBQ
marked this pull request as ready for review
July 4, 2025 22:07
Author
|
Same as before, the C++ / AMD64 Conda C++ AVX2 failures should not be due to our PRs but instead something on the Arrow main branch. The reason is that the same check is passing at apache#46099 |
Author
|
Found an Arrow issue on this matter: apache#47015 |
rscales
reviewed
Jul 8, 2025
rscales
reviewed
Jul 8, 2025
rscales
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLPrepare & SQLExecute Implementation and tests.
Most data fetching tests are covered in #55 , so I am not replicating the same tests in this PR as SQLGetData is the same for both SQLExecute and SQLExecuteDirect.