Implement SQLGetStmtAttr and SQLSetStmtAttr - #57
Merged
Conversation
alinaliBQ
reviewed
Jul 7, 2025
alinaliBQ
reviewed
Jul 7, 2025
rscales
force-pushed
the
sql-get-stmt-attr
branch
from
July 9, 2025 19:11
04ee639 to
e5cdd2b
Compare
rscales
marked this pull request as ready for review
July 9, 2025 21:13
alinaliBQ
reviewed
Jul 9, 2025
alinaliBQ
left a comment
There was a problem hiding this comment.
The statement attributes that end with *_PTR are pointers for array values. So we should test that we are able to set them to valid values
|
Example for setting and getting a pointer value: This example uses an array but some statement pointer attributes are for single values as well |
alinaliBQ
reviewed
Jul 11, 2025
alinaliBQ
left a comment
There was a problem hiding this comment.
Have few comments, and also need to fix the merge conflict and run the CI checks for C++ and Dev
alinaliBQ
reviewed
Jul 11, 2025
alinaliBQ
reviewed
Jul 11, 2025
alinaliBQ
left a comment
There was a problem hiding this comment.
LGTM, just waiting for the CI check results
alinaliBQ
approved these changes
Jul 11, 2025
|
The checks have passed. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement SQLGetStmtAttr and SQLSetStmtAttr