Fix Lint issues #34
Merged
Fix Lint issues #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
force-pushed
the
fix-lint-may-22
branch
from
9873036 to
010516f
Compare
alinaliBQ
commented
May 23, 2025
Comment on lines
15
to
+17
| cpp/src/arrow/c/dlpack_abi.h | ||
| cpp/src/arrow/flight/sql/odbc/odbc.def | ||
| cpp/src/arrow/flight/sql/odbc/install/install_amd64.cmd |
There was a problem hiding this comment.
Reminder to myself for writing in community PR:
The Apache Ignite install_amd64.cmd file does not have a license on it, so I assume .cmd files don't need licenses. Same logic for .def files; the Apache Ignite module.def file does not have a license.
alinaliBQ
force-pushed
the
fix-lint-may-22
branch
from
010516f to
c55d494
Compare
jduo
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
odbc.defandinstall_amd64.cmdto rat exclude licenses as these 2 files shouldn't need licenses