ODBC Linux rpm installer support - #171
Merged
Merged
Conversation
alinaliBQ
commented
Apr 16, 2026
| if ! grep -q "^${DRIVER_NAME}=" "$USER_ODBCINST_FILE"; then | ||
| if ! grep -q "^${DRIVER_NAME}=" "$SYSTEM_ODBCINST_FILE"; then | ||
| # Driver entry does not exist, add under [ODBC Drivers] | ||
| sed -i '' "/^\[ODBC Drivers\]/a\\ |
Author
There was a problem hiding this comment.
sed doesn't work well on Linux, changed to awk which works on Linux and macOS. awk is also already used by install_odbc_ini.sh script.
alinaliBQ
marked this pull request as ready for review
April 16, 2026 18:48
justing-bq
approved these changes
Apr 16, 2026
alinaliBQ
force-pushed
the
linux-rpm-installer
branch
2 times, most recently
from
April 17, 2026 21:40
ab8c39e to
c74a7b2
Compare
Revert "TEMP - Disable non-ODBC items" This reverts commit efa8d84. fix formatting Remove todos ODBC rpm Installer wrap up * installing `rpm` package fixed the `cpack` command issue * Fix cpack command on CI (merge into last commit when ready) Change to use `awk` so script works on both platforms Comment out `find` and `tree` steps Change build path to be under /arrow Since docker is mounted, changing build path to be in `/arrow` will allow host machine to access docker build contents TEMP - Disable non-ODBC items Add commands to find build folder Attempt to build RPM installer * not sure if `/build/cpp` can be accessed outside of docker. Hopefully it should. * add `rpm` dependency install Indicate RPM in workflow run Add rpm `postinstall` (not tested) Remove merge conflict code
alinaliBQ
force-pushed
the
linux-rpm-installer
branch
from
April 17, 2026 22:47
c74a7b2 to
88e6a82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Linux ODBC
.rpminstaller.In
install_odbc.sh, changed to useawkon unix platforms asseddoesn't work well on Linux.Add installer readme section.
Add
ARROW_FLIGHT_SQL_ODBC_INSTALLERoption.The
.rpminstaller installs: