Implement system_dsn for Mac - #154
Merged
Merged
Conversation
alinaliBQ
reviewed
Jan 29, 2026
justing-bq
marked this pull request as draft
January 29, 2026 18:04
justing-bq
force-pushed
the
macSystemDsn
branch
26 times, most recently
from
February 2, 2026 23:26
36bb302 to
97a053f
Compare
justing-bq
force-pushed
the
macSystemDsn
branch
12 times, most recently
from
February 6, 2026 20:31
1101033 to
5187728
Compare
alinaliBQ
force-pushed
the
apache-odbc
branch
from
February 6, 2026 21:46
3556804 to
9b6cd23
Compare
justing-bq
force-pushed
the
macSystemDsn
branch
5 times, most recently
from
February 7, 2026 00:29
ef4d391 to
b29790d
Compare
justing-bq
force-pushed
the
apache-odbc
branch
from
February 9, 2026 23:05
9544bdd to
a099ca6
Compare
alinaliBQ
force-pushed
the
apache-odbc
branch
from
February 10, 2026 19:06
9ebd46d to
555146a
Compare
justing-bq
force-pushed
the
macSystemDsn
branch
2 times, most recently
from
February 10, 2026 19:54
5b7c87e to
83ee4c5
Compare
justing-bq
marked this pull request as ready for review
February 10, 2026 19:55
alinaliBQ
self-requested a review
February 10, 2026 21:17
alinaliBQ
reviewed
Feb 10, 2026
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
@justing-bq Seems the workflow is failing, could you re-run the workflow to see if that fixes it?
Log: https://github.com/Bit-Quill/arrow/actions/runs/21880194655/job/63160219264?pr=154
Comment on lines
60
to
63
| Darwin) | ||
| n_jobs=$(sysctl -n hw.ncpu) | ||
| exclude_tests+=("arrow-flight-sql-odbc-test") | ||
| # TODO: https://github.com/apache/arrow/issues/40410 |
There was a problem hiding this comment.
Thanks for making this change. I think the test error is flakey and can still occur if we run the workflow multiple times.
justing-bq
force-pushed
the
macSystemDsn
branch
from
February 10, 2026 23:13
83ee4c5 to
82abc62
Compare
alinaliBQ
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tests were disabled due to system_dsn only being for Windows.
What changes are included in this PR?
system_dsn.h/cc have been reworked so they build on both Mac and Windows
Are these changes tested?
Yes
Are there any user-facing changes?
Yes