Resolve ODBC CI Build Errors - #129
Merged
Merged
Conversation
`ConnectionTest` sets up the handles, so the `this->...` handles will not be null at beginning of test.
alinaliBQ
commented
Oct 27, 2025
| } | ||
| } // namespace arrow::flight::sql::odbc | ||
|
|
||
| BOOL INSTAPI ConfigDSNW(HWND hwnd_parent, WORD req, LPCWSTR wdriver, |
Author
There was a problem hiding this comment.
If ConfigDSNW is under namespace arrow::flight::sql::odbc, then ConfigDSNW is defined as arrow::flight::sql::odbc::ConfigDSNW which is not recognized by stricted compilers. So ConfigDSNW needs to be defined on its own without any namespace
alinaliBQ
marked this pull request as ready for review
October 27, 2025 20:10
justing-bq
reviewed
Oct 27, 2025
| TEST(SQLFreeHandle, TestFreeNullHandles) { | ||
| SQLHENV env = NULL; | ||
| SQLHDBC conn = NULL; | ||
| SQLHSTMT stmt = NULL; |
Author
There was a problem hiding this comment.
The TestFreeNullHandles test was failing for me, ConnectionTest fixture sets up the handles, so the this->... handles will not be null at the beginning of test. I think originally TestFreeNullHandles wasn't a part of the ConnectionTest fixture.
justing-bq
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigDSNWnot found build issueTestFreeNullHandlestestConnectionTestsets up the handles, so thethis->...handles will not be null at beginning of test.