Fix FlightSQLODBCRemoteTestBase.TestSQLExecDirectDataQueryDefaultType test failure due to typo - #119
Merged
Merged
Conversation
alinaliBQ
marked this pull request as ready for review
October 8, 2025 22:50
|
How did this happen? I would have expected previous Github actions to catch this failure? |
justing-bq
approved these changes
Oct 8, 2025
Author
Currently the CI doesn't run any of the remote ODBC tests, only the mock tests or tests that do not require a remote instance are run. After we add Dremio docker container to part of the CI, this problem will be resolved. |
justing-bq
force-pushed
the
apache-odbc
branch
from
October 9, 2025 23:25
d9bb54c to
b32f3e6
Compare
alinaliBQ
force-pushed
the
fix-binary-test-error
branch
from
October 9, 2025 23:39
0745682 to
3be8b6a
Compare
justing-bq
force-pushed
the
apache-odbc
branch
from
October 10, 2025 16:49
b32f3e6 to
17f01d4
Compare
The precision should be 38 in the original code. I think it got changed to 0 by accident somewhere.
alinaliBQ
force-pushed
the
fix-binary-test-error
branch
from
October 14, 2025 22:02
3be8b6a to
8f144c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to get
FlightSQLODBCRemoteTestBase.TestSQLExecDirectDataQueryDefaultTypetest passing.The precision should be 38, not 0.
arrow/cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc
Line 558 in 12c0d6f