Skip to content

Remove RUN_ALL_TESTS as they are not needed #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alinaliBQ merged 4 commits into from
Sep 24, 2025
Merged

Remove RUN_ALL_TESTS as they are not needed #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8425bcc
Remove run_all_tests from connection test
alinaliBQ Sep 23, 2025
7f88ace
Fix segfault test issue
alinaliBQ Sep 23, 2025
5e764ac
Remove `RUN_ALL_TESTS` from `arrow_odbc_spi_impl_test`
alinaliBQ Sep 23, 2025
20e108b
remove unneeded label and restore test order
alinaliBQ Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/sql/odbc/flight_sql/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ set_target_properties(arrow_odbc_spi_impl_cli
target_link_libraries(arrow_odbc_spi_impl_cli arrow_odbc_spi_impl)

# Unit tests
add_arrow_test(arrow_odbc_spi_impl_test
add_arrow_test(odbc_spi_impl_test
SOURCES
accessors/boolean_array_accessor_test.cc
accessors/binary_array_accessor_test.cc
Expand Down
5 changes: 0 additions & 5 deletions cpp/src/arrow/flight/sql/odbc/flight_sql/flight_sql_connection_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,3 @@ TEST(PopulateCallOptionsTest, GenericOptionWithSpaces) {

} // namespace flight_sql
} // namespace driver

int main(int argc, char** argv) {
::testing::InitGoogleTest(&argc, argv);
return RUN_ALL_TESTS();
}
3 changes: 1 addition & 2 deletions cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ set(ARROW_FLIGHT_SQL_MOCK_SERVER_SRCS
add_arrow_test(flight_sql_odbc_test
SOURCES
columns_test.cc
connection_test.cc
connection_attr_test.cc
connection_info_test.cc
errors_test.cc
Expand All @@ -40,8 +41,6 @@ add_arrow_test(flight_sql_odbc_test
statement_test.cc
tables_test.cc
type_info_test.cc
# Connection test needs to be put last to resolve segfault issue
connection_test.cc
odbc_test_suite.cc
odbc_test_suite.h
# Enable Protobuf cleanup after test execution
Expand Down
6 changes: 0 additions & 6 deletions cpp/src/arrow/flight/sql/odbc/tests/connection_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include <sqltypes.h>
#include <sqlucode.h>

#include "google/protobuf/message_lite.h"
#include "gtest/gtest.h"

namespace arrow::flight::sql::odbc {
Expand Down Expand Up @@ -1022,8 +1021,3 @@ TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetStmtAttrDescriptor) {
}

} // namespace arrow::flight::sql::odbc

int main(int argc, char** argv) {
::testing::InitGoogleTest(&argc, argv);
return RUN_ALL_TESTS();
}
Loading