[Refactor] Remove reference of Configuration in odbc_connection.cc - #105
Merged
Conversation
alinaliBQ
commented
Sep 18, 2025
Comment on lines
+689
to
+690
| bool dsn_first = false; | ||
| bool driver_first = false; |
Author
There was a problem hiding this comment.
Changed variable name to fit arrow convention; but I didn't change variables everywhere though, as updating the variables are for a different ticket
alinaliBQ
marked this pull request as ready for review
September 19, 2025 18:15
alinaliBQ
changed the title
Configuration in odbc_connection.ccConfiguration in odbc_connection.cc
jduo
reviewed
Sep 19, 2025
jduo
reviewed
Sep 19, 2025
jduo
reviewed
Sep 19, 2025
justing-bq
approved these changes
Sep 19, 2025
Simply logic to check for first key value pair only
alinaliBQ
commented
Sep 19, 2025
jduo
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove reference of
Configurationin odbc_connection.cc which is in libraryodbcabstraction. The reasoning is thatConfigurationis inarrow_odbc_spi_impland this is a library thatodbcabstractiondepends on. I moved the logic for reading DSN values intoodbc_api.ccinstead, since that is a place that will result in no conflicts. The ODBC driver now does not save the DSN value in the connection string if the DSN value is put after Driver value.