This repository was archived by the owner on Dec 7, 2023. It is now read-only.
Update dependency for JDBC application #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forestmvey
reviewed
Aug 17, 2023
| @@ -90,6 +90,18 @@ | |||
| <artifactId>junit-jupiter</artifactId> | |||
| <version>${junit.jupiter.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Do we want to remove this dependency from the child pom since it's been added to the parent?
|
Am having compilation issues with JAVA 17 on this branch. I am also facing the same issues on main so I would assume it's an issue with my environment. |
| @@ -105,49 +96,40 @@ | |||
| <dependency> | |||
| <groupId>com.amazonaws</groupId> | |||
| <artifactId>aws-java-sdk-core</artifactId> | |||
| <version>${awssdk.version}</version> | |||
There was a problem hiding this comment.
Should dependency be loaded from the parent as well?
| <awssdk.version>1.11.870</awssdk.version> | ||
| <guava.version>32.0.0-jre</guava.version> | ||
| <awssdk.version>1.12.530</awssdk.version> | ||
| <guava.version>32.1.2-jre</guava.version> |
There was a problem hiding this comment.
Will declaring versions as a property work with Dependabot?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The build uses old dependencies that have vulnerability issues.
The JDBC don't have a parent pom and use own dependency list
Description
The dependency has been updated for aws core and jsoup
The shecksyles have been fixed
Related Issue
AT-1482
Tests performed/created
Unit tests:
All existing Unit tests passed
Manual verification:
export JAVA_HOME=/usr/libexec/java_home -v 1.8``mvn clean installexport JAVA_HOME=/usr/libexec/java_home -v 11``mvn clean installexport JAVA_HOME=/usr/libexec/java_home -v 16``mvn clean installAdditional Reviewers
@alexey-temnikov