Do not suggest convert in Rosalind example #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was probably an API mistake to allow `convert`ing between mutable, heap- allocated sequences. This is because `convert` is called implicit in Julia, and converting sequences: * Is slow compared to converting integers, causing unexpected allocations * Creates a new, mutable struct with a separate object identity. This can lead to nasty bugs when mutating the original sequence suddenly seems to have no effect, because the observed sequence is actually a distinct copy.
kescobo
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for these tutorials! ❤️
It was probably an API mistake to allow
converting between mutable, heap- allocated sequences. This is becauseconvertis called implicit in Julia, and converting sequences: