fix: remove unused fmt import and resolve non-constant format string …#19
Open
rockaxorb13 wants to merge 1 commit into
Open
fix: remove unused fmt import and resolve non-constant format string …#19rockaxorb13 wants to merge 1 commit into
rockaxorb13 wants to merge 1 commit into
Conversation
…in logrus.Warnf Signed-off-by: Aadityavardhan Singh <singhrashmi018@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves a static analysis failure caused by non-constant format strings being passed into logrus.Warnf functions across the node and communicator modules.
Previously, error messages were wrapped in fmt.Sprintf before being passed to the logger, which violates Go 1.21 strict vet checks regarding dynamic format strings. This PR strips the redundant fmt.Sprintf wrappers, updates the format verbs to %v to safely handle error types, and removes the resulting orphaned fmt import.
Changes Made
Testing