test: Add Initial Unit Tests for BiniBFT Proposal and Request Parsing#18
Open
Ayush-AM wants to merge 1 commit into
Open
test: Add Initial Unit Tests for BiniBFT Proposal and Request Parsing#18Ayush-AM wants to merge 1 commit into
Ayush-AM wants to merge 1 commit into
Conversation
Signed-off-by: Ayush Mahajan <140263932+Ayush-AM@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the initial set of unit tests for the BiniBFT proposal and request parsing logic on the
binibftbranch, fulfilling the requirements for Issue #16. No production behavior or implementation details have been modified.Changes Included
types_test.go: Added table-driven round-trip tests (serialization and deserialization) forTransaction,BlockData,BlockHeader, andBlock. Handled standard and edge cases (e.g., empty fields).verifier_test.go: Implemented table-driven tests forVerifyProposalandRequestsFromProposalto ensure they accurately extract the expectedRequestInfolists from valid block payloads.request_inspector_test.go: Added table-driven tests forRequestIDto verify the correct extraction ofClientIDandIDfrom serialized transactions.Related Issues
Acceptance Criteria Met
go test ./...onbinibft.-s) following standard Hyperledger contribution guidelines.