Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop 3.0 from GH matrix #224

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

argvniyx-enroute
Copy link
Contributor

@argvniyx-enroute argvniyx-enroute commented Sep 12, 2024

This is blocking the omniauth-saml security patch (#223; see action run: https://github.com/Betterment/test_track/actions/runs/10819720832/job/30018225320?pr=223). We're on Rails 7, so we don't need to worry about https://github.com/Betterment/test_track/pull/187/files#r1150893892

I'm skipping bumping rubocop.yml's TargetRubyVersion in the interest of time.

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Thanks for contributing to TestTrack!

/domain @Betterment/test_track_core
/platform @smudge

This is blocking the omniauth-saml security patch.
We're on Rails 7, so we don't need to worry about
https://github.com/Betterment/test_track/pull/187/files#r1150893892
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM

@smudge smudge merged commit 4b448e1 into Betterment:main Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants