Add Optional Environment Banner #212
Merged
+81
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smudge
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Love it! 👏
Any chance you can add a test for this? We have this with_env helper that allows us to change specific ENV vars on a per-example basis.
smudge
reviewed
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if an organization uses Test Track for multiple environments (e.g. production and stage), it can be a bit difficult to discern at first glance for which environment a user is managing a given split test.
This proposed change gives users the option to set a
DEPLOYMENT_ENV_LABELvariable in the.envor.env.localfile, which will subsequently be rendered in a bright red banner, like so:The banner is intentionally a tad obnoxious to make it glaringly obvious to the user which environment they are in.
When no
DEPLOYMENT_ENV_LABELvariable is set, the header renders as usual:I envision organizations using the existing state for production and the banner state for a non-production environment (or perhaps vice-versa).
/domain @Betterment/test_track_core