Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.2.2 upgrade #202

Merged

Conversation

argvniyx-enroute
Copy link
Contributor

@argvniyx-enroute argvniyx-enroute commented Sep 28, 2023

Summary

/task https://app.asana.com/0/0/1205605778894636/f

Update test-track to use ruby 3.2.2

  • Bump .ruby-version
  • Update code to be ruby 3.2.2 compatible
  • Clean up loose ends from Rails upgrades (deprecations, schema updates)

I had to bump the nanasess/setup-chromedriver action step to use v. 117, because 115 was failing (though it was a bit of a cargo cult so do let me know if there's a better way to go about this)
image

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Thanks for contributing to TestTrack!

/domain @Betterment/test_track_core

@argvniyx-enroute argvniyx-enroute marked this pull request as ready for review September 28, 2023 19:51
This reverts commit 8329174.
If somehow jobs fail again, I'll stick to using --amend.
Whaddya know, it actually happened. Here goes nothing
@argvniyx-enroute argvniyx-enroute force-pushed the argv/master/ruby-3-2-2-upgrade branch from d02002c to ed7f864 Compare September 28, 2023 21:28
smudge
smudge previously approved these changes Oct 2, 2023
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM

Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform TAFN -- just one suggestion

Co-authored-by: Nathan Griffith <[email protected]>
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM

@smudge
Copy link
Member

smudge commented Oct 2, 2023

Looks like merging is blocked -- filed an issue since I think this is an error with the branch configs.

@smudge
Copy link
Member

smudge commented Oct 4, 2023

@argvniyx-enroute merging is unblocked now, so I'm merging this!

@smudge smudge merged commit 7dc0a7b into Betterment:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants