fix: clamp fee invariant, clear tombstone on re-registration, gate in…

[meloball9993-star]

…it to deployer, emit record in event

• Clamp total fee sum to gross_amount to prevent invariant violation #683: clamp network_fee_amount so platform+network never exceeds gross
• Remove ArchivedMerchant tombstone on merchant re-registration #685: remove ArchivedMerchant tombstone on merchant re-registration
• Prevent front-running of contract initialization #684: require deployer auth on init to prevent front-running (both contracts)
• Correct event payload for payment_stored to include FeeSplit #686: emit PaymentRecord in payment_stored event data instead of ()

closes #683, closes #684, closes #685, closes #686

Description

Related Issues

Closes #

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• ⚡ Performance improvement
• ♻️ Refactor / Code cleanliness
• 📝 Documentation update
• 🔧 Tooling / CI configuration

Checklist

• My code follows the code style guidelines of this project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation (if applicable).
• My changes generate no new compiler warnings or lints.
• I have added tests that prove my fix is effective or that my feature works (if applicable).
• All new and existing tests pass locally.

Additional Notes / Screenshots

[drips-wave]

@meloball9993-star Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits