Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: use interface CIDR for auto-generated subnet, tests #1452

Merged
merged 9 commits into from
Jan 18, 2025

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Jan 18, 2025

No description provided.

Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit bdece29
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/678c321e5c3dee00080703f0

Copy link

codecov bot commented Jan 18, 2025

Bundle Report

Changes will increase total bundle size by 392 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gravity-ui-esm 3.71MB 392 bytes (0.01%) ⬆️

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 53.12500% with 15 lines in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (760b3e0) to head (bdece29).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/roles/discovery/role.go 59.09% 6 Missing and 3 partials ⚠️
pkg/roles/discovery/api_subnets.go 40.00% 2 Missing and 1 partial ⚠️
pkg/roles/discovery/subnet.go 33.33% 1 Missing and 1 partial ⚠️
pkg/extconfig/ip.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1452      +/-   ##
==========================================
+ Coverage   69.60%   69.72%   +0.12%     
==========================================
  Files         144      144              
  Lines        8031     8053      +22     
==========================================
+ Hits         5590     5615      +25     
+ Misses       1953     1946       -7     
- Partials      488      492       +4     
Flag Coverage Δ
e2e 42.13% <53.12%> (+0.47%) ⬆️
unittest 59.47% <3.12%> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 3ac27a2 into main Jan 18, 2025
17 of 18 checks passed
@BeryJu BeryJu deleted the discovery/make-better branch January 18, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant