Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: even more tests #1449

Merged
merged 16 commits into from
Jan 18, 2025
Merged

tests: even more tests #1449

merged 16 commits into from
Jan 18, 2025

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Jan 18, 2025

No description provided.

Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit 0958976
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/678c0f8e7c38af00087cb7c8

Copy link

codecov bot commented Jan 18, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 69.06%. Comparing base (3c73dea) to head (0958976).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cmd/cli/cli_health.go 63.63% 3 Missing and 1 partial ⚠️
pkg/roles/dhcp/dhcp_handler4.go 85.00% 3 Missing ⚠️
pkg/roles/dhcp/dhcp_handler4_discover.go 50.00% 1 Missing ⚠️
pkg/roles/dhcp/leases.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1449      +/-   ##
==========================================
+ Coverage   68.59%   69.06%   +0.47%     
==========================================
  Files         144      144              
  Lines        8068     8029      -39     
==========================================
+ Hits         5534     5545      +11     
+ Misses       2050     1997      -53     
- Partials      484      487       +3     
Flag Coverage Δ
e2e 41.73% <70.00%> (+0.34%) ⬆️
unittest 59.77% <12.50%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit f22879b into main Jan 18, 2025
17 checks passed
@BeryJu BeryJu deleted the tests/even-more branch January 18, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant