Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: use DPanic for etcd trace #1408

Merged
merged 4 commits into from
Jan 5, 2025
Merged

storage: use DPanic for etcd trace #1408

merged 4 commits into from
Jan 5, 2025

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Jan 5, 2025

should help find any code without transaction more easily

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit 3b8f652
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/677b15d351012a00085164f9

Copy link

codecov bot commented Jan 5, 2025

Bundle Report

Changes will increase total bundle size by 37.9kB (1.07%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gravity-ui-esm 3.57MB 37.9kB (1.07%) ⬆️

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.14%. Comparing base (45c4dd5) to head (3b8f652).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/storage/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
+ Coverage   60.06%   60.14%   +0.08%     
==========================================
  Files         137      137              
  Lines        7678     7681       +3     
==========================================
+ Hits         4612     4620       +8     
+ Misses       2618     2608      -10     
- Partials      448      453       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit aef77f1 into main Jan 5, 2025
18 checks passed
@BeryJu BeryJu deleted the storage/etcd-trace-dpanic branch January 5, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant