Skip to content

LeagueEndpoint update, new properties in championMastery and league#627

Open
kwiatkos0 wants to merge 7 commits intoBenFradet:developfrom
kwiatkos0:develop
Open

LeagueEndpoint update, new properties in championMastery and league#627
kwiatkos0 wants to merge 7 commits intoBenFradet:developfrom
kwiatkos0:develop

Conversation

@kwiatkos0
Copy link
Copy Markdown

@kwiatkos0 kwiatkos0 commented May 9, 2019

#621

#Deprecated

  • GetLeaguePositionsAsync

#Added

  • GetLeagueEntriesAsync
  • GetLeagueEntriesBySummonerIdAsync
  • GetGrandMasterLeagueAsync

#Fixed

  • LeaguePosition.cs
  • ChampionMastery.cs

Copy link
Copy Markdown
Owner

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kirides
Copy link
Copy Markdown
Contributor

kirides commented May 9, 2019

This kinda makes #622 obsolete

@JanOuborny
Copy link
Copy Markdown
Contributor

Thanks for your contribution 👍
Unfortunately, we have a merging problem now.
I propose that we merge #622 first, because it contains unit tests for the new methods and closer resembles the structure of the API. When it's done please rebase your branch onto develop and then we are going to merge the remaining changes.

@kwiatkos0
Copy link
Copy Markdown
Author

Ok, I can also add unit tests and other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants