JAAOUAN TAHA #7
Open
JAAOUAN TAHA #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelmoMusta
reviewed
Jan 22, 2023
| import java.util.Hashtable; | ||
|
|
||
| /** | ||
| * AnonymousRule is a Java class that defines a rule for linting of Java code. |
|
|
||
| Hashtable<String,Integer> anonymousInstanciations = new Hashtable<>(); | ||
| compilationUnit.accept(new AnonymousVisitor(anonymousInstanciations), null); | ||
| if(anonymousInstanciations.size()!=0){ |
|
|
||
|
|
||
|
|
||
| public static void jsonOutputFile(Collection<Violation> violations, Writer writer) throws IOException { |
There was a problem hiding this comment.
use a library to wrie json, like fasterxml or Gson
| writer.write(json.toString()); | ||
| writer.close(); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
e.printStackTrace is nit enough to decide the execution flow
| @Override | ||
| public void visit(IfStmt n, List<RuleWrapper> arg) { | ||
| if (!n.getThenStmt().isBlockStmt()) { | ||
| missingIfBrackets.add(new RuleWrapper(n.toString() ,n.getRange().isPresent()?n.getRange().get().begin.line:0)); |
There was a problem hiding this comment.
first , because here you can use Optional chaining.
2nd readability of code is hard when using ternary operations
| List<VariableDeclarator> localVariables = n.findAll(VariableDeclarator.class); | ||
| for (VariableDeclarator localVariable : localVariables) { | ||
| String locVar= localVariable.toString().split("=")[0] ; | ||
| if (!Character.isLowerCase(locVar.charAt(0))) { |
There was a problem hiding this comment.
!Character.isLowerCase ==> Character.isUpperCase
| } | ||
| @Override | ||
| public void visit(MethodDeclaration n, List<RuleCountWrapper> arg) { | ||
| super.visit(n, arg); |
There was a problem hiding this comment.
the Visitor pattern requires that the call to superior visits to be done at the end
| public void visit(MethodDeclaration n, List<RuleCountWrapper> arg) { | ||
| super.visit(n, arg); | ||
| int parameterCount = n.getParameters().size(); | ||
| int line = n.getRange().isPresent()?n.getRange().get().begin.line:0; |
There was a problem hiding this comment.
use Optional chaining
int line = n.getRange()
.map(r -> r.begin)
.map(b -> b.line)
.orElse(0);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.