Khattala Mohammed #6
Conversation
| @@ -0,0 +1,18 @@ | |||
| package com.ensao.gi5.test.constantes; | |||
|
|
|||
| public class Paths { | |||
| @@ -12,55 +12,54 @@ public class ImportWrapper { | |||
| private final String importDeclarationFQN; | |||
There was a problem hiding this comment.
This file contains unnecessary changes, be aware of the indentations :)
|
|
||
| @Override | ||
| public void visit(ClassOrInterfaceDeclaration n, Set<ElementWrapper> arg) { | ||
| arg.add(new ElementWrapper(n.getNameAsString(), n.getBegin().map(p -> p.line).orElse(-1))); |
There was a problem hiding this comment.
Chained method calls are preferable to be separated by a new line, like :
arg.add(new ElementWrapper(n.getNameAsString(), n.getBegin()
.map(p -> p.line)
.orElse(-1)));|
|
||
| @Override | ||
| public void visit(MethodDeclaration n, Set<ElementWrapper> localVariableWrappers) { | ||
| final BlockStmt body = n.getBody().get(); |
There was a problem hiding this comment.
Optional::get is not safe if the Optional instance is empty.
use Optional::isPresent before accessing the inner element.
| writer.close(); | ||
| } | ||
|
|
||
| public static void writeJson(Collection<Violation> violations, Writer writer) throws IOException { |
There was a problem hiding this comment.
could be
public static void writeJson(Collection<Violation> violations, Writer writer) throws IOException {
Gson gson = new Gson();
String obj = gson.toJson(violations);
writer.append(obj);
writer.flush();
writer.close();
}Gson can convert a Collection of objects into a JsonArray
| import java.util.Collection; | ||
|
|
||
| public class Utils { | ||
| Utils() { |
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
| final Set<ElementWrapper> names = new LinkedHashSet<>(); | ||
| compilationUnit.accept(new TypeNameVisitor(), names); | ||
| names.stream().filter(n->!Character.isUpperCase(n.getName().charAt(0))).forEach(n->{ |
There was a problem hiding this comment.
!Character.isUpperCase ==> Character.isLowerCase
| Set<MethodDeclaration> mds = new HashSet<MethodDeclaration>(); | ||
| compilationUnit.accept(new MethodVisitor(), mds); | ||
| mds.stream() | ||
| .filter(m -> m.getEnd().map(p -> p.line).orElse(-1) - m.getBegin().map(p -> p.line).orElse(-1) + 1 > 30) |
There was a problem hiding this comment.
for more readability
....
.filter(m -> {
final int endLine = m.getEnd()
.map(p -> p.line)
.orElse(-1);
final int beginLine = m.getBegin()
.map(p -> p.line)
.orElse(-1);
return endLine - beginLine + 1 > 30;
})
....|
|
||
| @Override | ||
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
| Set<BinaryExpr> bExps = new LinkedHashSet<BinaryExpr>(); |
There was a problem hiding this comment.
could be Set<BinaryExpr> bExps = new LinkedHashSet<>();
There was a problem hiding this comment.
I appreciate your relevant remarks sir and i promess i will take them into consideration.
No description provided.