ensao-lint (Mohamed El kadiri) #28
Conversation
|
|
||
| public class RuleFactory { | ||
| public Rule getRule(RulesEnum ruleSubClass) { | ||
| return switch(ruleSubClass) { |
| } | ||
|
|
||
| public boolean isAttributeNotConstant(AttributeWrapper attribute) { | ||
| return !attribute.isStatic() && !attribute.isFinal(); |
There was a problem hiding this comment.
if it is final, it doesn't mean it is static
example
private final String foo;There was a problem hiding this comment.
I had to ckeck for constants because they should start with an uppercase thats why i checked for both in this case
There was a problem hiding this comment.
I see.
a constant is static && final,
the opposite is not (static && final) so the condition will be isAttributeNotConstant => not static || not final
There was a problem hiding this comment.
I see, thanks for the clarification
| List<AttributeWrapper> attributes = new ArrayList<>(); | ||
| compilationUnit.accept(new AttributeVisitor(), attributes); | ||
| for (AttributeWrapper attribute: attributes) { | ||
| if (attribute.getAccessModifier().isEmpty()) { |
There was a problem hiding this comment.
Given that this is a wrapper, put this logic in wrapped method
if(attribute.hasNoAccessModifiers()) { .....| List<BooleanExpressionWrapper> booleanExpressions = new ArrayList<>(); | ||
| compilationUnit.accept(new BooleanExpressionVisitor(), booleanExpressions); | ||
| for (BooleanExpressionWrapper booleanExpression: booleanExpressions) { | ||
| if (checkIfBooleanExpressionHasMoreThanTwoOperands(booleanExpression)) { |
There was a problem hiding this comment.
checkIfBooleanExpressionHasMoreThanTwoOperands ==> booleanExpressionHasMoreThanTwoOperands
in the reading it will be if boolean expression has more than two operands
| } | ||
|
|
||
| public boolean checkIfBooleanExpressionHasMoreThanTwoOperands(BooleanExpressionWrapper booleanWrapper) { | ||
| String[] booleanOperands = booleanWrapper.getCondition().split("(&&) | (\\|\\|)"); |
There was a problem hiding this comment.
could be done by a visitor pattern
| List<MethodWrapper> methods = new ArrayList<>(); | ||
| compilationUnit.accept(new MethodVisitor(), methods); | ||
| for (MethodWrapper method: methods) { | ||
| if (checkIfMethodHasMoreThanThirtyLines(method)) { |
There was a problem hiding this comment.
checkIfMethodHasMoreThanThirtyLines ==> methodHasMoreThanThirtyLines
| } | ||
|
|
||
| public boolean checkIfMethodHasMoreThanThirtyLines(MethodWrapper methodWrapper) { | ||
| return methodWrapper.getStatements().size() > 30; |
There was a problem hiding this comment.
put this logic into the wrapper class
| } | ||
|
|
||
| public static String getTypeNameFromNodes(Node node) { | ||
| return ((TypeDeclaration<?>) node.getParentNode().get()).getNameAsString(); |
There was a problem hiding this comment.
Optional::get is to be called conditionally
Hello sir,
please free to share any advice or remarks regarding my work, that would be much appreciated.
Thank you in advance.