ElkhalifiZahia-GhammouriAsmae #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelmoMusta
reviewed
Jan 31, 2023
|
|
||
| @Override | ||
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
|
|
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
| List<FieldDeclaration> fields = compilationUnit.getCompilationUnit().findAll(FieldDeclaration.class); | ||
| fields | ||
| .forEach(fieldDeclaration -> { |
| .forEach(classOrInterface -> { | ||
| String name = classOrInterface.getNameAsString(); | ||
| int lineNumber = classOrInterface.getName().getBegin().get().line; | ||
| if (!Character.isUpperCase(name.charAt(0))) { |
There was a problem hiding this comment.
!Character.isUpperCase ==> Character.isLowerCase
| @Override | ||
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
| compilationUnit.getCompilationUnit().findAll(FieldDeclaration.class).forEach(fieldDeclaration -> { | ||
| String name = fieldDeclaration.getVariables().get(0).getNameAsString(); |
There was a problem hiding this comment.
if a field declaration contains more than one variable, this will not work
example :
private String foo, bar, alice;
| int lineNumber = fieldDeclaration.getVariables().get(0).getBegin().get().line; | ||
| if (!Character.isLowerCase(name.charAt(0))) { | ||
| final Violation violation = new Violation(); | ||
| violation.setDescription("Les attributs d'une classe commencent par une minuscule: " + name); |
There was a problem hiding this comment.
attributs d'instance et non pas de classe
| for (IfStmt clause : compilationUnit.getCompilationUnit().findAll(IfStmt.class)) { | ||
| Statement ifClause = clause.getThenStmt(); | ||
| Optional<Statement> elseClause = clause.getElseStmt(); | ||
| if (!(ifClause instanceof BlockStmt)) { |
There was a problem hiding this comment.
use visitor pattern to avoid type checks
| violation.setFileName(compilationUnit.getFileName()); | ||
| addViolation(violation); | ||
| } | ||
| if (elseClause.isPresent() && !(elseClause.get() instanceof BlockStmt)) { |
| // Check if the name contains underscores | ||
| if (!name.contains("_")) { | ||
| final Violation violation = new Violation(); | ||
| violation.setDescription("Enum element name must contain underscores: " + name); |
There was a problem hiding this comment.
not a must, if there is a need to separate things it will be by using an underscore
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
| compilationUnit.getCompilationUnit().findAll(ClassOrInterfaceDeclaration.class) | ||
| .forEach(classOrInterface -> { | ||
| long methodCount = classOrInterface.getMethods().size(); |
There was a problem hiding this comment.
why long ? int is largely enough
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
| List<VariableDeclarator> unusedVariables = compilationUnit.getCompilationUnit().findAll(VariableDeclarator.class) | ||
| .stream() | ||
| .filter(variable -> variable.getInitializer().isPresent() && variable.getInitializer().get().findAll(NameExpr.class, nameExpr -> nameExpr.getNameAsString().equals(variable.getNameAsString())).isEmpty()) |
There was a problem hiding this comment.
the boolean condition is too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementing all the rules 1-18 .