Projet Linter JAVA (BOUCHENTOUF Oussama - ALOUCHE Mustapha) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using jars is not correct in a maven project knowing that these jars could be added as dependencies in the pom.xml file |
BelmoMusta
reviewed
Jan 31, 2023
| import org.apache.commons.csv.CSVFormat; | ||
| import org.apache.commons.csv.CSVPrinter; | ||
|
|
||
| public class CSVFilePrinter implements Printer { |
| for (Statement statement : method.getBody().get().getStatements()) { | ||
| if (statement instanceof IfStmt) { | ||
| IfStmt ifStmt = (IfStmt) statement; | ||
| if (ifStmt.getCondition().findAll(BinaryExpr.class).size() >= 2) { |
There was a problem hiding this comment.
not only on if statements, it may be something like boolean condition = a && b || c && d;
| @Override | ||
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
| for (MethodDeclaration method : compilationUnit.getMethods()) { | ||
| int methodLines = method.getEnd().get().line - method.getBegin().get().line; |
There was a problem hiding this comment.
optional::get is to be called conditionally
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
| for (TypeDeclaration<?> type : compilationUnit.getTypes()) { | ||
| int methodCount = 0; | ||
| for (BodyDeclaration<?> member : type.getMembers()) { |
There was a problem hiding this comment.
use Visitor pattern to avoid casts and instanceof checkc
| @Override | ||
| public void apply(CompilationUnitWrapper compilationUnit) { | ||
| for (TypeDeclaration<?> type : compilationUnit.getTypes()) { | ||
| if (!Character.isUpperCase(type.getNameAsString().charAt(0)) || type.getNameAsString().contains("_")) { |
There was a problem hiding this comment.
!Character.isUpperCase ==> Character.isLowerCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.