MbarkiPr #13
Open
MbarkiPr #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelmoMusta
reviewed
Jan 30, 2023
| @@ -48,6 +48,24 @@ | |||
| <artifactId>commons-io</artifactId> | |||
| <version>2.11.0</version> | |||
| </dependency> | |||
| <!-- https://mvnrepository.com/artifact/com.google.guava/guava --> | |||
| <dependency> | |||
There was a problem hiding this comment.
Guava library is not necessary, use java collection framework instead
| @@ -46,6 +46,7 @@ public void run() { | |||
| final List<CompilationUnitWrapper> compilationUnitWrappers = new ArrayList<>(); | |||
| for (File source : sources) { | |||
| compilationUnitWrappers.add(Utils.getCompilationUnit(source)); | |||
| System.out.println(Utils.getCompilationUnit(source)); | |||
| import java.nio.file.Paths; | ||
| import java.util.Collection; | ||
|
|
||
| public class CSVFileWriter implements Printer { |
| import java.nio.file.Paths; | ||
| import java.util.Collection; | ||
|
|
||
| public class HtmlPrinter implements Printer { |
| public class JsonPrinter implements Printer{ | ||
| @Override | ||
| public void printViolations(Collection<Violation> violations) { | ||
| JSONArray jsonArray = new JSONArray(); |
There was a problem hiding this comment.
Use fasterxml or Gson to automatically render json objects
| import java.nio.file.Paths; | ||
| import java.util.Collection; | ||
|
|
||
| public class MarkdownPrinter implements Printer{ |
| compilationUnit.accept(new ConstVisitors(), m); | ||
|
|
||
|
|
||
| for(String s:m) { |
There was a problem hiding this comment.
use significant variable names, s and m are hard to understand
|
|
||
|
|
||
|
|
||
| Predicate<Object> p1= p->(Character.isUpperCase(p.toString().charAt(1))); |
There was a problem hiding this comment.
use significant variable names instead of p1
| .collect(Collectors.toSet()); | ||
|
|
||
|
|
||
| if (!answer.isEmpty()) { |
There was a problem hiding this comment.
this condition is useled, the for loop deals perfectly with empty collections
| final Set<NominationWrapper> nominations = new LinkedHashSet<>(); | ||
| compilationUnit.accept(new NominationVisitors(), nominations); | ||
| for (NominationWrapper m:nominations){System.out.println(m);} | ||
| Predicate<Object> p1= p->(Character.isLowerCase(p.toString().charAt(0))); |
There was a problem hiding this comment.
Use the correct type instead of Object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.