MAROUANE MOULOUE - AHMED ED-DAHBY #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelmoMusta
reviewed
Jan 30, 2023
| violation.setLine(constant.getLineNum()); | ||
| addViolation(violation); | ||
| } | ||
| if (!fieldName.contains("_")) { |
There was a problem hiding this comment.
not necessary to have _ in a variable name
|
|
||
| @Override | ||
| public boolean isActive() { | ||
| // TODO Auto-generated method stub |
There was a problem hiding this comment.
always remove irrelevant comments
| for (FieldDeclaration field : attributWrapper.getFields()) { | ||
| //get the name of the first variable of the field and check if it starts with a lower case | ||
|
|
||
| String fieldName = field.getVariable(0).getNameAsString(); |
There was a problem hiding this comment.
field.getVariable(0) should be generated to all the variables, because some attributes may be declared as follow :
private String foo, bar, tgz;| final List<String> types = compilationUnit.getTypes(); | ||
|
|
||
| for (String typeName : types) { | ||
| if (!Character.isUpperCase(typeName.charAt(0))) { |
There was a problem hiding this comment.
!Character.isUpperCase ==> Character.isLowerCase| violation.setFileName(compilationUnit.getFileName()); | ||
| addViolation(violation); | ||
| } | ||
| if(typeName.contains("_")) { |
There was a problem hiding this comment.
not necessary that a variable contains _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.