-
-
Notifications
You must be signed in to change notification settings - Fork 925
fix: Enabling moonshotai/kimi-k2-thinking and z-ai/glm-4.7 (most capable open-source models as of today) for code review with PAL
#382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… to the OpenRouter configuration to allow proper context. Without this fix, PAL thinks their context window is 32k, rendering these most powerful open-source models virtually unusable for code review tasks.
Summary of ChangesHello @shelpuk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the system's capabilities by integrating two highly capable open-source models, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds configuration for two new models, moonshotai/kimi-k2-thinking and z-ai/glm-4.7, to openrouter_models.json. This will ensure they are used with their correct context windows. I've made a couple of minor suggestions to improve consistency and correctness of the configuration values. Additionally, please consider updating the documentation in docs/custom_models.md to include these new models in the table of available OpenRouter models, as this will be helpful for users.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description
Enabling
moonshotai/kimi-k2-thinkingandz-ai/glm-4.7(most capable open-source models as of today) for code review with PAL.Added them to the OpenRouter configuration to allow proper context. Without this fix, PAL thinks their context window is 32k, rendering these most powerful open-source models virtually unusable for code review tasks.
Changes Made
moonshotai/kimi-k2-thinkingwith the proper context window configuration toconf/openrouter_models.json.z-ai/glm-4.7with the proper context window configuration toconf/openrouter_models.json.Testing
Please review our Testing Guide before submitting.
Run all linting and tests (required):
tests/simulator_tests/Related Issues
Fixes #(issue number)
Checklist
source venv/bin/activate && ./code_quality_checks.sh