The Broadside Update Literally Only One Person Asked For #2767
+410
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BetaCentari
requested review from
covertcorvid,
Bokkiewokkie and
a team
as code owners
DeltaFire15
requested changes
Feb 21, 2025
nsv13/code/modules/munitions/ship_weapons/ballistic_weapons/broadsides.dm
Outdated
Show resolved
Hide resolved
nsv13/code/modules/munitions/ship_weapons/ballistic_weapons/broadsides.dm
Outdated
Show resolved
Hide resolved
nsv13/code/modules/munitions/ship_weapons/ballistic_weapons/broadsides.dm
Show resolved
Hide resolved
nsv13/code/modules/munitions/ship_weapons/ballistic_weapons/broadsides.dm
Outdated
Show resolved
Hide resolved
nsv13/code/modules/munitions/ship_weapons/ballistic_weapons/broadsides.dm
Show resolved
Hide resolved
nsv13/code/modules/munitions/ship_weapons/ballistic_weapons/broadsides.dm
Show resolved
Hide resolved
nsv13/code/modules/munitions/ship_weapons/ballistic_weapons/broadsides.dm
Outdated
Show resolved
Hide resolved
DeltaFire15
previously approved these changes
Feb 21, 2025
Thank you @DeltaFire15 for your help! Sprites updated when not sleep deprived/eyestrained
DeltaFire15
previously approved these changes
Feb 21, 2025
Bokkiewokkie
requested changes
Feb 21, 2025
Thank you @Bokkiewokkie! (Sorry I'm silly)
AKA changes references from nuclear shells to depleted uranium shells
DeltaFire15
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR gives a much needed update to the Broadside Cannons, giving them more fleshed out mechanics with visuals to boot!
The weapons need to be cleaned, there's new ammunition, the weapon can now jam and much more.
Why It's Good For The Game
Makes the broadsides much more engaging and even buffs them to accommodate the added difficulty in managing them.
Also fixes a longtime bug from #2647
Testing Photographs and Procedure
Screenshots&Videos
Crate load the guns!
Aim the guns!
Clean the guns!
Get sent to the floor by the guns!
Stovepipe the guns!
Misfire the guns!
Changelog
🆑
add: Added crate loading for the broadside cannons
add: Added swabber for cleaning the broadsides
add: Added depleted uranium broadside shells
add: Added backblast to the broadsides
add: Added misfiring to the broadsides
add: Added aiming laser to the broadside cannons
add: Added swabbers to appropriate ships
balance: Increased rate of fire for broadsides
fix: fixed duplicating empty shells on the broadsides
soundadd: Added swabbing sound effect
imageadd: Added sprites for how dirty the broadsides are
code: Changed order of code for fire() proc
/:cl: