Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snake Area Mapping fix #2761

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bluewasabi24
Copy link
Contributor

@bluewasabi24 bluewasabi24 commented Feb 9, 2025

About The Pull Request

Accurately updates the mapping zones in Engineering on the Snake to reflect accurately. Specifically, labels the Armor pump area accurately and fully encompasses engineering maint.

Why It's Good For The Game

Turns out accurate areas affect how the in-game Map HUD labels things, so new players were having a hard time finding the APNW since it was originally marked as maintenance.

Also space should actually be space and not just maintenance.

Testing Photographs and Procedure

Screenshots&Videos

Before:
image

After
image

Changelog

🆑
fix: updated zones on the Snake to reflect accurately
/:cl:

Fixed engineering zones so empty space and armor pumps were labeled properly
@bluewasabi24 bluewasabi24 requested a review from a team as a code owner February 9, 2025 22:57
Copy link
Contributor

@SerynEngi SerynEngi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add an APC for the area you created. Remember to pull it from the ships grid instead of the reactor grid.

Also, there is a camera misplaced next to the bottom left armor pump.

Added APC to APNW room and fixed camera in APNW room
@bluewasabi24
Copy link
Contributor Author

You forgot to add an APC for the area you created. Remember to pull it from the ships grid instead of the reactor grid.

Also, there is a camera misplaced next to the bottom left armor pump.

Thank you very much! Updated accordingly.

@SerynEngi
Copy link
Contributor

SerynEngi commented Feb 11, 2025

Map will be approved on my end pending a successful test-merge this weekend.

Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
What's he doing in there

Removed new muni tech spawn from on top of the Broadsides
@bluewasabi24
Copy link
Contributor Author

image What's he doing in there

Fixed. I did it as a joke to mirror the other spawn on the other Broadside and just forgot to remove it.

Linters despise me. Attempting to do minor fixes to see if that fixes things.
Added fire axes
Removed jank overmap viewscreen in sci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants