Changing textfield to select #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into arrow-functionality
Renamed the App.tsx to AvatarForm Fixed Router errors as they we used twice in one component Fixed import router in AvatarForm
Use taildwind instead of Mui in Header and added redirection to AVANART title
About Us page
…ng-textfield-to-select
❌ Deploy Preview for avanart failed.
|
KristinaDudnyk
requested changes
Jun 10, 2024
| }); | ||
|
|
||
| saveAs(blob, "avatar.png"); | ||
| if (blob) { |
Collaborator
There was a problem hiding this comment.
Good error handling
| <ReactNiceAvatar | ||
| className="w-64 h-64 highres:w-80 highres:h-80" | ||
| hairColorRandom | ||
| shape={this.state.shape} |
Collaborator
There was a problem hiding this comment.
On line 113 you did destructuring, so you could directly access all of it without "this.state"
Collaborator
Author
There was a problem hiding this comment.
If you are talking about app component, this structure comes from react nice avatar and we didn't change it, but I worked on form page and tried to stick role and region on top of image after clicking the submit btn.
#33
Collaborator
There was a problem hiding this comment.
The Form looks all right to me, thank you Shadi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.