Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add continue_after_disconnect option (wait packet implementation) #44

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Add continue_after_disconnect option (wait packet implementation) #44

merged 4 commits into from
Dec 11, 2024

Conversation

ljwoods2
Copy link
Collaborator

@ljwoods2 ljwoods2 commented Dec 11, 2024 •
edited
Loading

Changes made in this Pull Request:

  • Implemented wait packet and continue_after_disconnect option to control it
  • Added dummy and live simulation engine tests for the new packet

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@ljwoods2 ljwoods2 changed the base branch from main to develop December 11, 2024 00:14
@ljwoods2 ljwoods2 changed the title Add contine_after_disconnect option (wait packet implementation) Add continue_after_disconnect option (wait packet implementation) Dec 11, 2024
@ljwoods2 ljwoods2 mentioned this pull request Dec 11, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.81%. Comparing base (59998f4) to head (7a59dc9).
Report is 2 commits behind head on develop.

Additional details and impacted files

@ljwoods2 ljwoods2 merged commit 57601ab into develop Dec 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ljwoods2