Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package detection and installation #12

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ianmkenney
Copy link
Member

basicrta was not being installed correctly, leading to import errors. Specify tool.setuptools.packages.find to automatically find the package and install correctly.

I tested the behavior with code similar to the below code block. Prior to these changes, the import basicrta failed.

micromamba create -p ./env/ python=3.12 -y
micromamba -p ./env/ run pip install ".[test]"

mkdir tmp/ # make sure we can import basicrta outside of the current directory
cd tmp/ && micromamba -p ../env/ run python -c "import basicrta; print(basicrta)"
cd ..
micromamba -p env/ run pytest -v basicrta/tests/ # confirm tests still pass

`basicrta` was not being installed correctly, leading to import
errors. Specify `tool.setuptools.packages.find` to automatically find
the package and install correctly.
@rsexton2 rsexton2 merged commit c9dec74 into main Dec 10, 2024
9 checks passed
@rsexton2
Copy link
Collaborator

Thank you @ianmkenney, looks good.

@rsexton2 rsexton2 deleted the bugfix/basicrta_package_installation branch December 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants