Convenience UI for uploading avatars to S3 buckets #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its not actually uploading yet, just tested that it writes and reads config
Removed extension method now that upload interacts with the editor progress bar
Response does not contain the url. We can try to construct a url, but it would be guesswork
The .asmdef will also prevent them from being included in a build, but this is extra explicit
neon-glowstick
changed the title
|
this is awesome, I think it needs to be on a separate repo however, (just so we don't add addons to the framework) bring it up with me when you got some time at the meeting or on discord and we can discuss how that would look :) |
|
I've made this into a package here https://github.com/neon-glowstick/BasisVr-S3Hosting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This PR adds a new Contrib folder for uploads and an implementation for uploading avatars to an S3 bucket.
To use the package add
"org.basisvr.contrib.upload.s3": "file:../../Contrib/Upload/S3"to manifest.json.The textfields are NOT serialized on the component. They are saved to a config file in Unitys PersistentDataPath locally on your machine. Use the Load/SaveDelete buttons to manage the config file.
I tested it with Cloudflare and a public R2 bucket in dev mode. Upload went fine and the avatar downloaded without issue into Basis.
Dependencies
I'm using the AWS S3 .net sdk to do the actual upload. It was downloaded using NugetForUnity then copied into the
Contrib/Upload/S3/Editor/librariesfolder. The AWS sdk packages are under the Apache 2.0 license, and the depend on Microsoft.Bcl.AsyncInterfaces which is under the MIT license.